COMP: Fix build against ITK install adding "expat_external.h" install rule #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rule This commit fixes a regression introduced in 9e337d3 (ENH: Update expat files) by pull request InsightSoftwareConsortium#2755 on 2021-09-27. ITK issue is InsightSoftwareConsortium#3186 and problem was first documented in Slicer/SlicerExecutionModel#137
github-actions
bot
added
area:ThirdParty
jcfr
added a commit
to jcfr/SlicerExecutionModel
that referenced
this pull request
Feb 10, 2022
This commit updates the verison of ITK to integrate fix from InsightSoftwareConsortium/ITK#3187
jcfr
added a commit
to Slicer/SlicerExecutionModel
that referenced
this pull request
Feb 10, 2022
This commit updates the verison of ITK to integrate fix from InsightSoftwareConsortium/ITK#3187
dzenanz
approved these changes
Feb 10, 2022
dzenanz
approved these changes
Feb 14, 2022
|
Thanks @dzenanz 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression introduced in 9e337d3 (ENH: Update expat
files) by pull request #2755 on 2021-09-27.
ITK issue is #3186 and problem was first documented in Slicer/SlicerExecutionModel#137
@hjmjohnson @dzenanz
PR Checklist
[ ] Added test (or behavior not changed)[ ] Updated API documentation (or API not changed)[ ] Added license to new files (if any)[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5[ ] Added ITK examples for all new major features (if any)Refer to the ITK Software Guide for
further development details if necessary.