Test snapshot corruption #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/corrupt-snapshot
branch
from
a74eb5f to
b8aef62
Compare
This should allow us to manually corrupt a file, and then we can test whether we can detect the file corruption, for example using checksums in snapshot files.
jorisdral
force-pushed
the
jdral/corrupt-snapshot
branch
from
b8aef62 to
f74efac
Compare
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
|
Ready for review now! |
wenkokke
approved these changes
Jan 24, 2025
In snapshot corruption tests, we're going to pick a random file to corrupt, but to pick a file we first have to list the directory contents.
* Replace `UniqueList` by `Set` * Replace `Path` by the new `FsPathComponent`
jorisdral
force-pushed
the
jdral/corrupt-snapshot
branch
from
f74efac to
7e88c2f
Compare
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A next step would be to apply the same explicit corruption method to the statemachine tests.
In parallel, we can add silent corruption to
fs-sim, which currently only simulates noisy corruption. We could use this silent corruption simulation to eventually replace the explicitflipFileBitcalls