Make RefExceptions catchable in IOSim
#607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
force-pushed
the
jdral/iosim-refs
branch
from
1805ef5 to
6e45900
Compare
dcoutts
requested changes
Mar 5, 2025
jorisdral
force-pushed
the
jdral/iosim-refs
branch
from
6e45900 to
0b2ef94
Compare
Double release checks in the `DeRef` pattern will throw exceptions in `IO`, which we can't catch in `IOSim`. To improve reliability of catching `RefException`s in `IOSim`, we remove the forgotten refs check from the `DeRef` pattern.
This improves reliability of catching `RefException`s in `IOSim`. In `IOSim`, we can not catch exceptions that were thrown in `IO`.
This serves as a sanity check for the changes introduced by previous commits
Now that we use `unsafeIOToPrim` on a more granular level, some side effects like clearing the `globalForgottenRef` were not happening at the right time. Adding a stricter `unsafeIOToPrimStrict` version seems to help.
jorisdral
force-pushed
the
jdral/iosim-refs
branch
from
0b2ef94 to
9a93adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RefExceptions are currently thrown fromIO, but we can not catch these exceptions inIOSim. This PR makes changes to ensure we can catch (almost all) exceptions in any monad that has the right constraints. The only exceptions we still can't catch outside ofIOare exceptions thrown by theDeRefpattern.