Fix broken update process from all-in-one #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, and it works. :D As a co-worker, I can't merge. |
|
@whikloj , can we get you to test? I still don't have a working VirtualBox. 😕 |
rosiel
approved these changes
Oct 19, 2021
|
Since I've tested, I can approve but can't merge because of the same institution policy. |
|
Building a pre- #203 box to test with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (link)
What does this Pull Request do?
Follow up to the discussion after the merge of #201 , which was failing if you had an existing site. The playbook would halt on composer require because the lock file had older versions of packages and the one-at-a-time update process was unable to complete.
What's new?
This change removes explicit references to composer packages that are already listed as requirements by islandora or islandora_defaults.
It also puts the three packages islandora/islandora_defaults, islandoar/openseadragon and islandora/controlled_access_terms onto one line in the required package list, this is valid and makes composer update them all at once so that a hanging version specification in the lock file doesn't hold it up.
How should this be tested?
Given a playbook that was built prior to the #201 changes , run 'vagrant provision' and observe the full run and that all Islandora packages are now at the 2.x branches.
Additional Notes:
Successfully tested both the test above and a clean run.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers
@whikloj @seth-shaw-unlv @rosiel