Islandora Deux in Karaf #83

whikloj · 2015-10-16T14:39:53Z

This branch builds on @acoburn's work to have a common features.xml file for the islandora camel services and load them in a Karaf container.
It mvn build install's them, loads them at start up in the karaf 4.0.1 container.
It also implements @ruebot's PRs #80 and #82.

whikloj · 2015-10-22T03:34:46Z

Has anyone had a chance to try this out? @acoburn @ruebot @DiegoPino @daniel-dgi

If it's no good I'd rather trash it then continue to let it hang.

ruebot · 2015-10-22T10:31:32Z

I will test it today since I am now free of giving presentations at camp!

ruebot · 2015-10-22T13:09:00Z

types vagrant up

ruebot · 2015-10-22T14:43:11Z

@whikloj ok, testing results:

I can create a collection object, and it syncs to fcrepo
I can create a basic image object, and it syncs to fcrepo
The derivative service does not work with basic image
The basic image object does not have any children -- OBJ datastream

Any output from karaf or catalina you want me to drop in here?

whikloj · 2015-10-22T14:45:36Z

Nope that matches with mine, basic-image images aren't working because the camel route doesn't see the file attachment and therefore doesn't process it. I'm working on that.

ruebot · 2015-10-22T14:47:04Z

Ah, cool.

daniel-dgi · 2015-10-27T18:31:49Z

@whikloj There's other options for you on this. The most obvious one is having micro services accept a single, standardized serialization format instead of multipart/form-data messages. I've never been a fan of multipart/form-data, but couldn't come up with a better approach at the time. Maybe it's best we talked out our options?

I keep coming back to bags. Zipped bags oughta do the trick to assemble both metadata and files in a format that's acceptable. Though that may cause logistical problems if you're zipping a 2GB file on the Drupal server.

Paging the other committers: @ruebot @acoburn @DiegoPino

And some other folks, too :) @dmoses @ppound @rosiel @qadan

Feel free to invite friends to this discussion :D

whikloj · 2015-11-03T14:26:36Z

@daniel-dgi I'm more concerned why this doesn't work though. It worked then I switched the version of camel and now it doesn't so I'm just wondering if it is something I did.

But I take your point that we may want to look at how we are pushing out of Drupal.

Is this of any use then? I like it because it has Karaf 4.0.1, but if your developing of something else we should probably be on the same page.

DiegoPino · 2015-11-03T14:39:47Z

@whikloj, i'm blaming jetty9. I like the idea of doing it without multipart, but still we should be able to use multipart so i'm for fixing first multipart, then evaluating a different route. Since i'm doing a lot of recoding i will try to debug the message headers to see what is going on. Is that a good idea?

daniel-dgi · 2015-11-03T14:47:14Z

it's definitely jetty.

@DiegoPino I'm glad you're willing to go there, because I'm not thrilled at the prospect. I was planning on a wait and see approach under the assumption the problem is upstream. But if you're feeling pro-active enough, go for it!

@whikloj Not really writing anything just yet, but working through api changes to accomodate this without multipart. Also looking into how best to share code between web services through the use of OSGi registered services. Means things might get a little more java-beanish, but should be good in the long-term.

ruebot · 2015-11-03T14:51:45Z

Check this out: @Islandora-CLAW/7-x-2-x-committers -- we can tag each other now 😄

Switch http4 back to http

Also doesn't load on Karaf boot, load after it's up.

whikloj · 2015-11-20T04:57:12Z

BooYah! This worked for me, but I think I probably need a @ruebot to try it out.

ruebot · 2015-11-20T12:27:06Z

@whikloj oh snap. This harmonizes #111?

ruebot · 2015-11-20T13:07:10Z

drupal/islandora_basic_image/islandora_basic_image.module

@@ -184,7 +185,28 @@ function islandora_basic_image_node_postupdate($node) {
    );
  }

-  httprl_request("http://127.0.0.1:8888/islandora/rest/basic-image/?uuid={$node->uuid}",
+  httprl_request("http://127.0.0.1:8888/cxf/islandora/image/{$node->uuid}",
                 $options);


Port should be 8181

@ruebot

Move islandora-components to their own script. Update to ensure we use the correct version of fcrepo and blaze graph Add @ruebot's work from daniel-dgi/islandora#1

whikloj · 2015-11-20T17:33:54Z

@Islandora-CLAW/7-x-2-x-committers for review por favor

DiegoPino · 2015-11-20T17:38:34Z

@whikloj , will fire a vagrant machine and test. But looks pretty good for me.

ruebot · 2015-11-20T17:52:26Z

@whikloj pulling down, and building.

ruebot · 2015-11-20T19:31:42Z

@whikloj I am happy to report that it works.

whikloj · 2015-11-20T19:33:06Z

W000000000t!!!

DiegoPino · 2015-11-20T20:56:16Z

No pretty pictures to show but it works fine here!

ruebot · 2015-11-20T21:35:07Z

My proposal for how to proceed:

merge this since it goes into the dev branch.
merge Use CXF to expose web services #111 into 7.x-2.x (waiting on @nigelgbanks)
merge 7.x-2.x-dev into 7.x-2.x
start working from 7.x-2.x again... or create a new dev branch

@Islandora-CLAW/7-x-2-x-committers - thoughts?

acoburn · 2015-11-20T21:41:20Z

👍 on @ruebot's proposal. Step 3 will probably require some significant work on the dev branch, but I can work on that. IMO, we'll end up no dev branch.

DiegoPino · 2015-11-20T22:33:11Z

👍 on that, but we keep 2.x-dev right (smile) or it's already in the past? (i like it, even when merging will be always a pain) ? Also Means @acoburn will have to pull/write all pretty tests again (poor @acoburn)

ruebot · 2015-11-20T22:38:47Z

@DiegoPino #65 is still open, and will need to be rebased/merged at some point soon. We should get rid of the dev branch as soon as possible because it really complicates things IMO.

acoburn · 2015-11-21T01:45:36Z

@DiegoPino it's really not a problem to recreate the tests.

ruebot · 2015-11-23T18:21:29Z

@daniel-dgi are you cool with my proposal? If so, I'll go ahead and merge this one. Then we'll need somebody to merge #111, and then we begin the big job merging dev with master 😱

daniel-dgi · 2015-11-23T18:23:08Z

Go for it.

On Nov 23, 2015, at 2:21 PM, Nick Ruest [email protected] wrote:

@daniel-dgi are you cool with my proposal? If so, I'll go ahead and merge this one. Then we'll need somebody to merge #111, and then we begin the big job merging dev with master

—
Reply to this email directly or view it on GitHub.

Islandora Deux in Karaf

ruebot and others added 9 commits October 9, 2015 12:13

Addressing #56 & #57 -- @whikoj to work on this as well.

01c5478

Moving to karaf boot level installation

8ebad21

More changes for Karaf

08a7e00

Fix some endpoints

e575edc

More tweaks

d009131

Fix camel version and add mustache to islandora-sync

c58edc3

Remove unused karaf and script files.

936bade

Restore islandora-commands.sh and add Solr configuration fix.

16b5902

Remove extra sync.sh, this is installed in islandora-camel.sh

b8070ab

This was referenced Nov 6, 2015

added basic tests to image service #65

Closed

camel-script 2.15.2 and jruby WARNING #110

Closed

Use CXF to expose web services #111

Merged

whikloj added 2 commits November 12, 2015 14:43

Adding logging and upping to camel 2.15.2

a32e82e

Implement cxf for servlets

6702d8f

Switch http4 back to http

This was referenced Nov 18, 2015

Bump Fedora up to 4.4.0. Address #95 #96

Closed

Update fcrepo to 4.4.0 in the vagrant build #95

Closed

whikloj added 2 commits November 19, 2015 16:44

Implements CXF work from #111

462e820

Also doesn't load on Karaf boot, load after it's up.

Fix features

e61197b

ruebot reviewed Nov 20, 2015
View reviewed changes

Code review changes and...

b3c7504

Move islandora-components to their own script. Update to ensure we use the correct version of fcrepo and blaze graph Add @ruebot's work from daniel-dgi/islandora#1

ruebot added a commit that referenced this pull request Nov 23, 2015

Merge pull request #83 from whikloj/add-to-karaf

6995e3b

Islandora Deux in Karaf

ruebot merged commit 6995e3b into Islandora:7.x-2.x-dev Nov 23, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Islandora Deux in Karaf #83

Islandora Deux in Karaf #83

whikloj commented Oct 16, 2015

whikloj commented Oct 22, 2015

ruebot commented Oct 22, 2015

ruebot commented Oct 22, 2015

ruebot commented Oct 22, 2015

whikloj commented Oct 22, 2015

ruebot commented Oct 22, 2015

daniel-dgi commented Oct 27, 2015

whikloj commented Nov 3, 2015

DiegoPino commented Nov 3, 2015

daniel-dgi commented Nov 3, 2015

ruebot commented Nov 3, 2015

whikloj commented Nov 20, 2015

ruebot commented Nov 20, 2015

ruebot Nov 20, 2015

whikloj Nov 20, 2015

whikloj commented Nov 20, 2015

DiegoPino commented Nov 20, 2015

ruebot commented Nov 20, 2015

ruebot commented Nov 20, 2015

whikloj commented Nov 20, 2015

DiegoPino commented Nov 20, 2015

ruebot commented Nov 20, 2015

acoburn commented Nov 20, 2015

DiegoPino commented Nov 20, 2015

ruebot commented Nov 20, 2015

acoburn commented Nov 21, 2015

ruebot commented Nov 23, 2015

daniel-dgi commented Nov 23, 2015

Islandora Deux in Karaf #83

Islandora Deux in Karaf #83

Conversation

whikloj commented Oct 16, 2015

whikloj commented Oct 22, 2015

ruebot commented Oct 22, 2015

ruebot commented Oct 22, 2015

ruebot commented Oct 22, 2015

whikloj commented Oct 22, 2015

ruebot commented Oct 22, 2015

daniel-dgi commented Oct 27, 2015

whikloj commented Nov 3, 2015

DiegoPino commented Nov 3, 2015

daniel-dgi commented Nov 3, 2015

ruebot commented Nov 3, 2015

whikloj commented Nov 20, 2015

ruebot commented Nov 20, 2015

ruebot Nov 20, 2015

Choose a reason for hiding this comment

whikloj Nov 20, 2015

Choose a reason for hiding this comment

whikloj commented Nov 20, 2015

DiegoPino commented Nov 20, 2015

ruebot commented Nov 20, 2015

ruebot commented Nov 20, 2015

whikloj commented Nov 20, 2015

DiegoPino commented Nov 20, 2015

ruebot commented Nov 20, 2015

acoburn commented Nov 20, 2015

DiegoPino commented Nov 20, 2015

ruebot commented Nov 20, 2015

acoburn commented Nov 21, 2015

ruebot commented Nov 23, 2015

daniel-dgi commented Nov 23, 2015