Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[Money total sum customization] #2811

Closed
3 tasks done
RoninZULU opened this issue Nov 2, 2023 · 10 comments · Fixed by #2822
Closed
3 tasks done

[Money total sum customization] #2811

RoninZULU opened this issue Nov 2, 2023 · 10 comments · Fixed by #2822
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user

Comments

@RoninZULU
Copy link

Please confirm the following:

  • I've checked the current issues for duplicate issues.
  • I've requested a single (only one) feature/change in this issue. It complies with the One Request Per GitHub Issue (ORPGI) rule.
  • My issue is well-defined and describes how it should be implemented from UI/UX perspective.

What do you want to be added or improved?

Hello! I would like to suggest that the calculation of the total money in the "Accounts" section could be customized for which accounts we want to do the sum. I have 3 money accounts in liquid and one investment and for me it doesn't make much sense to add to the "total" the money I have in the investments because it change every day, but it would help me to see how much total money I have between the three liquid money accounts

Why do you need it?

  • I have several money accounts, but one of them being investments changes every day. It doesn't make sense that the total sum takes that number, since it is changing.

How do you imagine it?

No response

@RoninZULU RoninZULU added the user request Feature/improvement requested by an user label Nov 2, 2023
@ILIYANGERMANOV
Copy link
Collaborator

Hey @RoninZULU you can use "Include account" from the account edit modal to determine whether it should be included in the total balance? Does that work?

@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Nov 2, 2023
@CedricLindigkeit
Copy link
Contributor

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @CedricLindigkeit! 🎉
Issue #2811 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please unassign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@Aritzherrero4
Copy link
Contributor

I don't really like this change. I think the account section should include all the accounts as it represents the real money you have. The "liquid" money is represented on the mail tab balance that already excludes hidden accounts.

I see the use case for the change though but it would be nice to make it optional. A new setting could be added to set if the excluded accounts should be taken into consideration on the "Account" tab.

I'm sorry for bringing this late to the table @CedricLindigkeit @ILIYANGERMANOV

How do you guys see this proposal?

@ILIYANGERMANOV
Copy link
Collaborator

I don't really like this change. I think the account section should include all the accounts as it represents the real money you have. The "liquid" money is represented on the mail tab balance that already excludes hidden accounts.

I see the use case for the change though but it would be nice to make it optional. A new setting could be added to set if the excluded accounts should be taken into consideration on the "Account" tab.

I'm sorry for bringing this late to the table @CedricLindigkeit @ILIYANGERMANOV

How do you guys see this proposal?

Then, the UI should display both Liquid and Excluded. IMO, having both is the best. Wdyt?

@CedricLindigkeit
Copy link
Contributor

I think this is a good suggestion, but I'm not sure where exactly I would put this option in the UI

@Aritzherrero4
Copy link
Contributor

Maybe is the general app settings? Where the "hide balance" option is?

@ILIYANGERMANOV
Copy link
Collaborator

Why not just show both balances:

  • better UX cuz more information available
  • less software complexity

@CedricLindigkeit
Copy link
Contributor

CedricLindigkeit commented Nov 19, 2023

That would be a valid possibility.

Would you allow the user to specify where the account is included (for example in Home too), or should this option really ONLY be for the account overview?

EDIT: I think your suggestion is the best way, @ILIYANGERMANOV

@Aritzherrero4
Copy link
Contributor

Aritzherrero4 commented Nov 19, 2023

I would keep it only for the accounts tab. The balance on the main page should only display the "useful" balance. It's what you need to quick check.

I'm OK with showing both balances all the time on the accounts tab.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants