Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Money total sum customization #2824

Conversation

CedricLindigkeit
Copy link
Contributor

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the "Contributing Rules".
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

Screenrecorder-2023-11-20-13-00-55-910.mp4

What's changed?

Describe with a few bullets what's new:

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

  • Translations might not be perfect

In what cases your code won't work?

  • It should work in every case

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Replace ISSUE_NUMBER with your issue number (for example Closes #1234). If you've done that correctly, you'll see the issue title linked when previewing your PR description.

Troubleshooting CI failures

If you see any of the PR checks failing (❌) go to Actions and find it there. Or simply click "Details" next to the failed check and explore the logs to see why it has failed.

Detekt

Detekt is a static code analyzer for Kotlin that we use to enforce code readibility and good practices.

To run Detekt locally:

./gradlew detekt

If the Detekt errors are caused by a legacy code, you can suppress them using a basline.

Detekt baseline (not recommended)

./scripts/detektBaseline.sh

Lint

We use the standard Android Lint plus Slack's compose-lints as an addition to enforce proper Compose usage.

To run Lint locally:

./scripts/lint.sh

If the Lint errors are caused by a legacy code, you can suppress them using a basline.

Lint baseline (not recommended)

./scripts/lintBaseline.sh

Unit tests

If this job is failing this means that your changes break an existing unit test. You must identify the failing tests and fix your code.

To run the Unit tests locally:

./gradlew testDebugUnitTest

@CedricLindigkeit
Copy link
Contributor Author

I hope this way satifies both of you, @ILIYANGERMANOV @Aritzherrero4
Some of the translations still need to be checked though.

@Aritzherrero4
Copy link
Contributor

Thank you very much! I like it.

@ILIYANGERMANOV ILIYANGERMANOV merged commit 6982c7f into Ivy-Apps:main Nov 20, 2023
6 checks passed
@CedricLindigkeit CedricLindigkeit deleted the Money_total_sum_customization_#2811 branch November 20, 2023 22:52
nvllz pushed a commit to nvllz/ivy-wallet that referenced this pull request Dec 23, 2023
* Removed account inclusion from the account screen

* Renamed the variables

* Added new label to distinguish between total and total without excluded accounts

* Fixed detekt error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example issue
3 participants