Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #298 #299

Conversation

dodu94
Copy link
Member

@dodu94 dodu94 commented Jun 5, 2024

Description

This commit fixes #298 that was due to the LibManager operating directly on the library dataframe of the configuration instead of on a copy of it. Tests have been added to cover for this bug in the future

Fixes #298

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Testing

Error has been reproduced with CI testing and then solved

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • Coverage is >80%

@dodu94 dodu94 linked an issue Jun 5, 2024 that may be closed by this pull request
@dodu94 dodu94 added the bug Something isn't working label Jun 5, 2024
@dodu94 dodu94 requested a review from alexvalentine94 June 5, 2024 14:24
Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is clear for fix of issue and tests have been added. Thanks Davide

@alexvalentine94 alexvalentine94 merged commit 2a72ffa into master Jun 7, 2024
8 checks passed
@dodu94 dodu94 deleted the 298-bug-jade-breaks-when-generating-inputs-on-windows branch November 6, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - JADE breaks when generating inputs on windows
2 participants