Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of v3.1.0 #322

Merged
merged 97 commits into from
Oct 11, 2024
Merged

Release of v3.1.0 #322

merged 97 commits into from
Oct 11, 2024

Conversation

alexvalentine94
Copy link
Collaborator

Description

v3.1.0 release with several bug fixes and introduction of F4Enix dependency for I/O handling. Method for handling fetching of inputs from IAEA open benchmark repository also included.

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Other changes

  • This change requires a documentation update
  • (If Benchmark) This requires additional data that can be obtained from:
    • Benchmark data 1
    • Benchamrk data 2

Testing

All additions have been rigorously tested.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • [] Coverage is >80%

alexvalentine94 and others added 26 commits July 22, 2024 15:48
Introduction of F4Enix dependency for MCNP input and output parsing
Add Codecov support for better code coverage tracking
…DDR-materials

Add contribution tracking for sddr materials
Aspis 88 - post processing atlas title improvement
…-rmode0-to-mcnp-benchmarks

add keyword RMODE 0 to mcnp benchmarks for D1SUNED run
…om-log-class-to-python-logging-module

213 feature request   switch from log class to python logging module
Simplify logic in output to handle multiple code and fix ITER cylinder SDDR
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 73.39901% with 54 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
jade/gui.py 48.19% 43 Missing ⚠️
jade/computational.py 60.00% 4 Missing ⚠️
jade/input_fetch.py 94.44% 3 Missing ⚠️
jade/expoutput.py 92.30% 2 Missing ⚠️
jade/configuration.py 0.00% 1 Missing ⚠️
jade/exceptions.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
jade/acepyne.py 9.76% <100.00%> (ø)
jade/constants.py 100.00% <100.00%> (ø)
jade/excelsupport.py 99.65% <100.00%> (ø)
jade/inputfile.py 85.95% <100.00%> (ø)
jade/main.py 80.48% <ø> (ø)
jade/output.py 75.74% <ø> (ø)
jade/plotter.py 96.05% <ø> (ø)
jade/postprocess.py 37.97% <ø> (ø)
jade/sphereoutput.py 96.05% <ø> (ø)
jade/status.py 87.82% <ø> (ø)
... and 8 more

Copy link
Member

@dodu94 dodu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In depth review was already done for each individual PR that are being pushed now to main. We may consider being more strict with the acceptable coverage in the future

@dodu94 dodu94 merged commit 7407026 into master Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants