Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite handleStringData to use CompositeIdFetcher #12004

Closed
koppor opened this issue Oct 16, 2024 · 2 comments · Fixed by #12009
Closed

Rewrite handleStringData to use CompositeIdFetcher #12004

koppor opened this issue Oct 16, 2024 · 2 comments · Fixed by #12009
Assignees
@Red12138-java
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) dev: code-quality Issues related to code or architecture decisions FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Oct 16, 2024 •
edited
Loading

org.jabref.gui.externalfiles.ImportHandler#handleStringData should be rewritten to use org.jabref.logic.importer.CompositeIdFetcher#performSearchById. One could first call org.jabref.logic.importer.CompositeIdFetcher#containsValidId. If this returns false, then continue at tryImportFormats else call performSearchById.

Remove unsued methods then.
@koppor koppor added good first issue An issue intended for project-newcomers. Varies in difficulty. dev: code-quality Issues related to code or architecture decisions labels Oct 16, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Oct 16, 2024
@koppor koppor mentioned this issue Oct 16, 2024
Closed
@Red12138-java
Copy link
Contributor

Hi, Koppor! I am really interested in this issue! I want to try my best to solve this issue.Could you assign this issue to me?thank you so much!!

@koppor koppor added 📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

⚠ Note that this issue will become unassigned if it isn't closed within 30 days.

🔧 A maintainer can also add the Pinned label to prevent it from being unassigned automatically.

Happy coding! 🚀

@koppor koppor moved this from Free to take to Assigned in Good First Issues Oct 17, 2024
Red12138-java pushed a commit to Red12138-java/jabref that referenced this issue Oct 17, 2024
@JinyiZhuRed
Rewrite handleStringData to use CompositeIdFetcher JabRef#12004
41b4e4c 
add a no-args constructor to CompositeIdFetcher.java
@koppor koppor mentioned this issue Oct 17, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
@Red12138-java @JinyiZhuRed
Fix for #12004issue:Rewrite handleStringData to use CompositeIdFetcher (
2c44ee1 
#12009)

* Rewrite handleStringData to use CompositeIdFetcher #12004
add a no-args constructor to CompositeIdFetcher.java

* delete the no-args constructor.

---------

Co-authored-by: u7744550 <[email protected]>
@github-project-automation github-project-automation bot moved this from Assigned to Done in Good First Issues Oct 17, 2024
ExrosZ pushed a commit to ExrosZ/jabref that referenced this issue Oct 17, 2024
@Red12138-java @JinyiZhuRed @ExrosZ-Alt
Fix for #12004issue:Rewrite handleStringData to use CompositeIdFetcher (
e992a24 
JabRef#12009)

* Rewrite handleStringData to use CompositeIdFetcher JabRef#12004
add a no-args constructor to CompositeIdFetcher.java

* delete the no-args constructor.

---------

Co-authored-by: u7744550 <[email protected]>
ExrosZ pushed a commit to ExrosZ/jabref that referenced this issue Oct 17, 2024
@Red12138-java @JinyiZhuRed @ExrosZ-Alt
Fix for #12004issue:Rewrite handleStringData to use CompositeIdFetcher (
88647c7 
JabRef#12009)

* Rewrite handleStringData to use CompositeIdFetcher JabRef#12004
add a no-args constructor to CompositeIdFetcher.java

* delete the no-args constructor.

---------

Co-authored-by: u7744550 <[email protected]>
ExrosZ pushed a commit to ExrosZ/jabref that referenced this issue Oct 21, 2024
@Red12138-java @JinyiZhuRed @ExrosZ-Alt
Fix for #12004issue:Rewrite handleStringData to use CompositeIdFetcher (
500da7c 
JabRef#12009)

* Rewrite handleStringData to use CompositeIdFetcher JabRef#12004
add a no-args constructor to CompositeIdFetcher.java

* delete the no-args constructor.

---------

Co-authored-by: u7744550 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Red12138-java Red12138-java

Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) dev: code-quality Issues related to code or architecture decisions FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Good First Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #12004issue:Rewrite handleStringData to use CompositeIdFetcher Red12138-java/jabref
2 participants
@koppor @Red12138-java