Fix for #12004issue:Rewrite handleStringData to use CompositeIdFetcher #12009
Conversation
add a no-args constructor to CompositeIdFetcher.java
| @@ -19,6 +19,10 @@ public CompositeIdFetcher(ImportFormatPreferences importFormatPreferences) { | |||
| this.importFormatPreferences = importFormatPreferences; | |||
| } | |||
|
|
|||
| public CompositeIdFetcher() { | |||
| importFormatPreferences = null; | |||
There was a problem hiding this comment.
No, you need to pass the preferences. - You have it availble in line 101 in ImportHandler. Store it in a class variable and use the class variable in line 367 of ImportHandler.
There was a problem hiding this comment.
Oh, sorry. I see. I have deleted the constructor. I will create a pull request again. Thank you so much.
There was a problem hiding this comment.
No additional pull request. Just push. As your teammate already did!
There was a problem hiding this comment.
Okkk!thank you
There was a problem hiding this comment.
Tested. Works. Thank you for the PR.
Since this was really a quick-win, maybe you can tackle another issue? Now you can be more relaxed and really take this as opportunity to level-up your code reading and code writing skills.
We offer a curated list of issues at https://github.com/orgs/JabRef/projects/3/views/3.
JabRef#12009) * Rewrite handleStringData to use CompositeIdFetcher JabRef#12004 add a no-args constructor to CompositeIdFetcher.java * delete the no-args constructor. --------- Co-authored-by: u7744550 <[email protected]>
JabRef#12009) * Rewrite handleStringData to use CompositeIdFetcher JabRef#12004 add a no-args constructor to CompositeIdFetcher.java * delete the no-args constructor. --------- Co-authored-by: u7744550 <[email protected]>
JabRef#12009 started using CompositeIdFetcher for fetching logic. This removes the dead code functions in ImportHandler
* feat: add ssrn urls to CompositeIdFetcher * refactor: delete now-dead functions in ImportHandler #12009 started using CompositeIdFetcher for fetching logic. This removes the dead code functions in ImportHandler * docs: add ssrn import to changelog * style: conform to stylecheck * style: address requested changes * docs: correct DOI capitalisation --------- Co-authored-by: Oliver Kopp <[email protected]>
JabRef#12009) * Rewrite handleStringData to use CompositeIdFetcher JabRef#12004 add a no-args constructor to CompositeIdFetcher.java * delete the no-args constructor. --------- Co-authored-by: u7744550 <[email protected]>
Refactor the handleStringData method as requirements and add a no-args constructor to CompositeFetcher.java, the reason to add no-args constructor is that performSearchById is not a static method which could not be used directly.
"Closes #12004".
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)