Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export translator field to msoffice 2007 xml #3632

Merged
merged 6 commits into from
Jan 14, 2018
Merged

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 12, 2018

Upcoming issue from #1750
While testing this I noticed that the import was broken (due to the recent export filetype/extension changes), fixed that, too.

Directly use Bookauthors and Translator for import from xml
Add test


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

Siedlerchr and others added 4 commits January 12, 2018 23:18
Fix importer selection
Directly use Bookauthors and Translator for import from xml
Add test
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 12, 2018
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but the additional test files apparently don't match.

% Encoding: UTF-8

@Misc{2016,
title = {MeinArtikel},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like the bibtex version of the xml file below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing. But shouldn't travis normally have noticed this?

…into office007translator

* 'office007translator' of https://github.com/JabRef/jabref:
  Add Gitter badge and hint (#3630)
  Update CHANGELOG.md
  Add UI elements for validation in the preferences dialog
  Change style
  Reactivate validation in entry editor
@Siedlerchr
Copy link
Member Author

As the feedback was okay I merge this in

@Siedlerchr Siedlerchr merged commit e32bdc8 into master Jan 14, 2018
@Siedlerchr Siedlerchr deleted the office007translator branch January 14, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants