Feature/visualize residuals with noise map #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhayes777
approved these changes
May 10, 2023
Comment on lines
+194
to
+195
| if not self.should_visualize(paths=paths): | ||
| return |
There was a problem hiding this comment.
Could be a decorator I guess
Comment on lines
+219
to
+221
| def visualize_before_fit_combined( | ||
| self, analyses, paths: af.DirectoryPaths, model: af.Collection | ||
| ): |
Comment on lines
+69
to
+70
| def should_plot(name): | ||
| return plot_setting(section="dataset", name=name) |
There was a problem hiding this comment.
To me it seems like this function doesn't need to be defined locally.
| @@ -226,3 +222,63 @@ def std_list_of_lists_from( | |||
| return self._value_list_of_lists_from( | |||
| array=array, settings=settings, value_str="std" | |||
| ) | |||
|
|
|||
| def _value_list_of_lists_via_array_list_from( | |||
Comment on lines
+22
to
+35
| if region is None: | ||
| return "" | ||
| elif region == "fpr": | ||
| return "FPR" | ||
| elif region == "eper": | ||
| return "EPER" | ||
| elif region == "parallel_fpr": | ||
| return "Parallel FPR" | ||
| elif region == "parallel_eper": | ||
| return "Parallel EPER" | ||
| elif region == "serial_fpr": | ||
| return "Serial FPR" | ||
| elif region == "serial_eper": | ||
| return "Serial EPER" |
There was a problem hiding this comment.
Consider using a dictionary
|
Will adddress comments the day Euclid deadlines disappear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves visualization.