feature/jax #64
Merged
feature/jax #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhayes777
commented
Jan 22, 2024
| y = data.apply_mask(mask=np.invert(fpr_mask)).binned_across_columns | ||
| y = data.apply_mask(mask=fpr_mask).binned_across_columns |
There was a problem hiding this comment.
I don't really know what happened here but for some reason the test only passed without the inversion. If it looks dodgy I'll investigate further
rhayes777
commented
Jan 22, 2024
Comment on lines
+141
to
+144
| mask=aa.Mask1D( | ||
| sum(mask_1d_list) == len(mask_1d_list), | ||
| pixel_scales=mask_1d_list[0].pixel_scales, | ||
| ), |
There was a problem hiding this comment.
Masks aren't arrays anymore so this had to be cast back explicitly. I might try to make it implicit again
There was a problem hiding this comment.
Actually I'm not totally sure what the point of this operation is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support new jax compliant autoarray