Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add plaintext sample #66

Merged
merged 6 commits into from
Oct 30, 2022
Merged

add plaintext sample #66

merged 6 commits into from
Oct 30, 2022

Conversation

tashima42
Copy link
Contributor

Added plain text Fernando Pessoa and Shakespeare poems to code samples

Closes #59

@tashima42 tashima42 changed the title add plaintext samples DRAFT: add plaintext samples Oct 25, 2022
JoaoDanielRufino
JoaoDanielRufino requested changes Oct 25, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you leave just one .txt file ?

@tashima42 tashima42 changed the title DRAFT: add plaintext samples add plaintext sample Oct 27, 2022
JoaoDanielRufino
JoaoDanielRufino requested changes Oct 28, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tashima42

Please, you also need to update scanner_test.go

@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest Hacktoberfest event label Oct 28, 2022
@tashima42
Copy link
Contributor Author

Done, @JoaoDanielRufino

JoaoDanielRufino
JoaoDanielRufino approved these changes Oct 30, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest-accepted Hacktoberfest accepted pull request label Oct 30, 2022
@JoaoDanielRufino JoaoDanielRufino merged commit 8b12162 into JoaoDanielRufino:master Oct 30, 2022
@JoaoDanielRufino JoaoDanielRufino mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoDanielRufino JoaoDanielRufino JoaoDanielRufino approved these changes

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Plain Text code sample for tests
2 participants
@tashima42 @JoaoDanielRufino