Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine TypeScript version support #68

Closed
JoshuaKGoldberg opened this issue Dec 4, 2022 · 0 comments · Fixed by #119
Closed

Determine TypeScript version support #68

JoshuaKGoldberg opened this issue Dec 4, 2022 · 0 comments · Fixed by #119
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: cleanup Tech debt or other code/repository cleanups 🧹

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 4, 2022 •
edited
Loading

Overview

What version range of TypeScript should this plugin support?

Actual Behavior

Apparently it goes back to 2.0:

eslint-plugin-expect-type/src/rules/expect.ts

Line 611 in 312aa1e

// ts2.0 doesn't have `isVariableStatement`

Expected Behavior

I'd propose going along with https://github.com/DefinitelyTyped/DefinitelyTyped/#support-window: versions of TypeScript less than 2 years old.

Let's:

  • Explicitly document this in the README.md
  • Remove that TypeScript support shim
@JoshuaKGoldberg JoshuaKGoldberg added type: docs status: accepting prs Please, send a pull request to resolve this! 🙏 type: cleanup Tech debt or other code/repository cleanups 🧹 labels Dec 4, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 4, 2023
Merged
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 19, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 19, 2023
@JoshuaKGoldberg
feat: clarify TypeScript support range (#119)
838434b 
## PR Checklist

- [x] Addresses an existing open issue: fixes #68
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Aligns to the DefinitelyTyped support range and removes a workaround for
TS2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: cleanup Tech debt or other code/repository cleanups 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: clarify TypeScript support range JoshuaKGoldberg/eslint-plugin-expect-type
1 participant
@JoshuaKGoldberg