chore: set TypeScript version range to >=4.2 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
force-pushed
the
ts-version-range
branch
4 times, most recently
from
24c3066 to
3046da3
Compare
JoshuaKGoldberg
force-pushed
the
ts-version-range
branch
from
3046da3 to
0d542e3
Compare
JoshuaKGoldberg
commented
May 4, 2023
danvk
approved these changes
May 4, 2023
| name: Format | ||
|
|
||
| on: | ||
| pull_request: ~ |
There was a problem hiding this comment.
TIL that ~ means null in YAML. Perhaps just write it as null for clarity?
Is this saying that we don't want to run format checks on PR branches? Why would that be?
There was a problem hiding this comment.
Heh I went the opposite conclusion in https://github.com/JoshuaKGoldberg/template-typescript-node-package - that it implies "run on all of them", which null feels ... the opposite to me?
It means we run format checks on:
- All pull request commits
- Commits to
main
|
🎉 This is included in version v0.3.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Sets the minimum tested TypeScript version to 4.2, with a matrix of tests across versions up through
5.0andlatest.Borrows some GHA configuration from https://github.com/JoshuaKGoldberg/template-typescript-node-package.