-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PkgTemplates work on 1.0 #19
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 98.67% 98.64% -0.03%
==========================================
Files 11 11
Lines 378 296 -82
==========================================
- Hits 373 292 -81
+ Misses 5 4 -1
Continue to review full report at Codecov.
|
.travis.yml
Outdated
- julia -e 'Pkg.clone(pwd()); Pkg.test("PkgTemplates"; coverage=true)' | ||
before_script: | ||
- git config --global user.name "Chris de Graaf" | ||
- git config --global user.email "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should add a comment explaining. When you LibGit2.commit
without these options, it raises an exception, and Travis OSX and AppVeyor both don't have this preconfigured (interestingly, it works on Linux).
(A couple of commits are made as part of package generation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, you may not want to expose your email address in the commit history. Up to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it's all over the commit history but I will remove it from the CI files 😅. Editing that commit.
{{#COVERALLS}} | ||
- C:\projects\julia\bin\julia -e "cd(Pkg.dir(\"{{PKGNAME}}\")); Pkg.add(\"Coverage\"); using Coverage; Coveralls.submit(process_folder())" | ||
{{/COVERALLS}} | ||
{{/AFTER}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default appveyor.yml script should be now based upon the Appveyor.jl package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I'm going to change this in the next PR which will update the real functionality.
ef0d43a
to
50ed265
Compare
This doesn't change much if any of the package functionality, it just makes it run and all the test pass. So it's basically creating packages for 0.6. Next up is to use
Pkg.generate
etc.One other change is with the default plugin file templates, there was a bug fixed in Mustache which lets us write much more clearly.