Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate packages for 1.0 #20

Merged
merged 14 commits into from
Oct 15, 2018
Merged

Generate packages for 1.0 #20

merged 14 commits into from
Oct 15, 2018

Conversation

christopher-dG
Copy link
Member

@christopher-dG christopher-dG commented Sep 26, 2018

Most of this is actually removing features that I don't consider useful enough to keep around.

Options to Template that have been removed:

  • years: if you're generating a new project, you probably want the current year
  • requirements: doesn't make sense since a goal of templates is reuse and requirements aren't a constant
  • gitconfig: I don't think this was ever used

force is no longer an option for generate, it raises an error when the path already exists.

Plugin file templates have been updated, but I still need to test them.

Use Pkg to generate Project.toml and the src entrypoint, and add the
Test package from the stdlib.
Also remove some options to generate that added complexity: force,
temp_dir, and ssh. Trying to create a package at an already-existent path
is now an error no matter what. The ssh keyword to generate has been
moved to Template.

TODO:
- Update the file templates to current standards.
- Clean up the gen_plugin signature and update those docs.
- Pkg.add requirements provided to the template.
- Update interactive_template's requirements gathering to use a loop.
- **Make smaller commits.**
Removed keywords to Template: years, requirements, and gitconfig.
TODO: A new asciicast.
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #20 into master will increase coverage by 0.54%.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   98.64%   99.19%   +0.54%     
==========================================
  Files          11       11              
  Lines         296      248      -48     
==========================================
- Hits          292      246      -46     
+ Misses          4        2       -2
Impacted Files Coverage Δ
src/plugins/gitlabci.jl 100% <ø> (ø) ⬆️
src/plugin.jl 100% <100%> (ø) ⬆️
src/plugins/githubpages.jl 100% <100%> (ø) ⬆️
src/plugins/documenter.jl 96.42% <100%> (ø) ⬆️
src/generate.jl 100% <100%> (ø) ⬆️
src/template.jl 98.3% <90%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1830d...9195fc8. Read the comment docs.

@christopher-dG christopher-dG mentioned this pull request Sep 26, 2018
@iamed2
Copy link
Member

iamed2 commented Sep 26, 2018

I do think requirements can be useful but since it would have to change completely we can just implement it if it ever it becomes useful to us.

README.md Outdated Show resolved Hide resolved
defaults/appveyor.yml Outdated Show resolved Hide resolved
{{/CODECOV}}
{{#COVERALLS}}
- julia -e 'cd(Pkg.dir("{{PKGNAME}}")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder())'
- julia -e 'using Pkg; Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder())'
{{/COVERALLS}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ararslan I think you have a new an improved suggestion for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope it hides test failures because it runs during the script not after.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, well, I assume you're referring to the new codecov: true and coveralls: true. @iamed2 and I noticed that it seems to mask test errors and report success. So perhaps best not to tout it just yet...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eric-Alex race condition

@christopher-dG
Copy link
Member Author

Currently testing at https://github.com/christopher-dG/TestPkg.jl

defaults/gitlab-ci.yml Outdated Show resolved Hide resolved
@christopher-dG christopher-dG changed the title WIP: Generate packages for 1.0 Generate packages for 1.0 Oct 12, 2018
@omus omus merged commit e47672b into master Oct 15, 2018
@omus omus deleted the cdg/1.0pkg branch October 15, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants