-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate packages for 1.0 #20
Conversation
Use Pkg to generate Project.toml and the src entrypoint, and add the Test package from the stdlib. Also remove some options to generate that added complexity: force, temp_dir, and ssh. Trying to create a package at an already-existent path is now an error no matter what. The ssh keyword to generate has been moved to Template. TODO: - Update the file templates to current standards. - Clean up the gen_plugin signature and update those docs. - Pkg.add requirements provided to the template. - Update interactive_template's requirements gathering to use a loop. - **Make smaller commits.**
Removed keywords to Template: years, requirements, and gitconfig.
TODO: A new asciicast.
d6e37bc
to
41f4f1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 98.64% 99.19% +0.54%
==========================================
Files 11 11
Lines 296 248 -48
==========================================
- Hits 292 246 -46
+ Misses 4 2 -2
Continue to review full report at Codecov.
|
I do think |
{{/CODECOV}} | ||
{{#COVERALLS}} | ||
- julia -e 'cd(Pkg.dir("{{PKGNAME}}")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder())' | ||
- julia -e 'using Pkg; Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder())' | ||
{{/COVERALLS}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ararslan I think you have a new an improved suggestion for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope it hides test failures because it runs during the script not after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, well, I assume you're referring to the new codecov: true
and coveralls: true
. @iamed2 and I noticed that it seems to mask test errors and report success. So perhaps best not to tout it just yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eric-Alex race condition
Currently testing at https://github.com/christopher-dG/TestPkg.jl
|
Most of this is actually removing features that I don't consider useful enough to keep around.
Options to
Template
that have been removed:years
: if you're generating a new project, you probably want the current yearrequirements
: doesn't make sense since a goal of templates is reuse and requirements aren't a constantgitconfig
: I don't think this was ever usedforce
is no longer an option forgenerate
, it raises an error when the path already exists.Plugin file templates have been updated, but I still need to test them.