Fix deprecations #21
Closed
Fix deprecations #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![femtocleaner[bot]](https://avatars.githubusercontent.com/in/4123?s=60&v=4){kind=small}
ararslan
approved these changes
Sep 26, 2018
|
Already included in #20, but should we merge anyways? |
|
It just means you'd need to rebase your PR atop master once this is merged, which would be kind of annoying for you. Up to you, but if it were me I would just close this PR and merge yours. |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 11 11
Lines 296 296
=======================================
Hits 292 292
Misses 4 4Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a number of deprecations for you