Various updates #22
Merged
Various updates #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the potential to cause breakage, since previous packages that relied on this will now throw a MethodError. However, there doesn't seem to be any way to do this without causing a ton of ambiguities; this can have a cascading effect on other packages that want to check for ambiguities to avoid inadvertently introducing them. A workaround is described in the README.
This ensures the exports work
|
[bump] Would be nice to get this merged if possible 😊🙏 PS: Minor issue, PPS: I wasn't sure the best way to do this, so I submitted a PR here timholy#1 |
Remove second exported Leaves
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage ? 56.29%
=========================================
Files ? 3
Lines ? 302
Branches ? 0
=========================================
Hits ? 170
Misses ? 132
Partials ? 0
Continue to review full report at Codecov.
|
|
Still passes! If there are no objections, I will merge this in the next few days. |
This was referenced Jan 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a grab-bag of mostly-independent commits. The intent of each commit is described in its message. Feel free to accept some but not others. Note the ambiguity test may not run assuming the nightly binaries haven't caught up yet to JuliaLang/julia#30291.