Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project.toml and Manifest.toml #34

Closed
wants to merge 1 commit into from

Conversation

EricForgy
Copy link
Contributor

@EricForgy EricForgy commented Feb 24, 2019

Hi,

I closed my previous PR to add Project.toml and Manifest.toml. The first time I opened it was because I wanted to submit some PRs.

Now, there is another reason.

https://github.com/JuliaRegistries/General/blob/master/A/AbstractTrees/Deps.toml#L4-L6

That ☝️ says AbstractTrees depends on Test so when I add this as a dependency to my package, it pulls in all Test dependencies to my Manifest. I'd like to keep my Manifest.toml as lean as possible.

@timholy
Copy link
Member

timholy commented Jan 7, 2020

Superseded by #22

@timholy timholy closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants