Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle binary response as octet-stream #85

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

qiaojunfeng
Copy link
Contributor

Hi, thanks for the nice package, it works very well!

Here I want to make some small changes to smoothen the user experience of handling file upload/download.
Specifically, there are some changes to the openapi-generator, see
OpenAPITools/openapi-generator#20355

Here is an example to reproduce the issue, and demonstrating the benefit of the PRs,
https://github.com/qiaojunfeng/test-julia-OpenAPI

Thanks again for creating this package!

@pfitzseb pfitzseb requested a review from tanmaykm January 2, 2025 13:46
@tanmaykm
Copy link
Member

tanmaykm commented Jan 2, 2025

I am still not convinced about OpenAPITools/openapi-generator#20355 🙂. But this is independent and seems like a good addition. Thanks.

@tanmaykm tanmaykm merged commit f18935e into JuliaComputing:main Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants