-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Julia template for binary string #20355
base: master
Are you sure you want to change the base?
Conversation
Thanks @qiaojunfeng, I shall check this out this weekend. |
The effect of this change would be that if something is specified as binary format, it would now be generated as a I would like to understand more the reason why you feel we should have this changed in the openapi generated code? |
Thanks @tanmaykm! |
Thanks @qiaojunfeng, I think the issue here is missing check for the |
@qiaojunfeng Here's my recommended changes: https://github.com/OpenAPITools/openapi-generator/compare/master...tanmaykm:tan/fixfile?expand=1 |
It seems there is a small issue with generated julia function signature, when handling
To better reproduce this, I set up a MWE here
https://github.com/qiaojunfeng/test-julia-OpenAPI/tree/main
Since this is a julia-specific issue, I will ping technical committee member @tanmaykm. Thanks!
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)