-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Julia v0.7 #160
Closed
Closed
Update to Julia v0.7 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in #159, Travis does not seem to respond... |
Closed
I'll try to activate our gitlab ci today! |
There is an |
Merged
Merged
This seems to be superseded by #169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally on Kubuntu 18.04 with an Nvidia GPU, all tests pass for me. There is still one deprecation warning in line 140 of context.jl (https://github.com/JuliaGPU/OpenCL.jl/compare/master...ranocha:update_v07?expand=1#diff-6cc00ffb6d6452cf5b665d33b6f45a90R140). However, if I replace
cfunction
with@cfunction
(and the argument type tuple accordingly to getf_ptr = @cfunction($payload, Nothing, (Ptr{Cchar}, Ptr{Cvoid}, Csize_t))
), I get some errors:Thus, I've not changed this part and there is still a deprecation warning.
During the first
using OpenCL
, there are some deprecation warnings such as