Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on KLDivergences.jl #76

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Remove dependence on KLDivergences.jl #76

merged 5 commits into from
Jan 12, 2022

Conversation

theogf
Copy link
Member

@theogf theogf commented Nov 9, 2021

All the code of KLDivergences has been moved to Distributions.jl, see: JuliaStats/Distributions.jl#1414
Except for the rrule on PDMat which might need to be moved here (let's see how the tests go)

@theogf
Copy link
Member Author

theogf commented Nov 9, 2021

Tests fail because of JuliaGaussianProcesses/AbstractGPs.jl#242

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #76 (9b2a9d3) into master (5e475e3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9b2a9d3 differs from pull request most recent head 1792b6b. Consider uploading reports for the commit 1792b6b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files           4        4           
  Lines         279      279           
=======================================
  Hits          267      267           
  Misses         12       12           
Impacted Files Coverage Δ
src/sparse_variational.jl 96.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e475e3...1792b6b. Read the comment docs.

Copy link
Member

@st-- st-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be fine, happy to have this merged @theogf - just requires a patch bump I think?

@theogf
Copy link
Member Author

theogf commented Jan 11, 2022

I'll rerun tests to make sure!

@theogf theogf merged commit 094bb40 into master Jan 12, 2022
@theogf theogf deleted the tgf/remove_kl branch January 12, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants