Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to Column-Major #42

Merged
merged 22 commits into from
Feb 7, 2022
Merged

Switching to Column-Major #42

merged 22 commits into from
Feb 7, 2022

Conversation

mileslucas
Copy link
Member

  • bump versions
  • fix orientation in morphology.jl
  • get geometry working with reorientation
  • get masking working with correct orientation, and add center as a keyword arg
  • rewrite scaling for reorientation
  • update tests to use column-major orientation
  • rm nomralize_psf
  • simplify injection code for now
  • remove Compat

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #42 (627706b) into main (341aa9f) will increase coverage by 1.07%.
The diff coverage is 96.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   88.40%   89.47%   +1.07%     
==========================================
  Files           9        9              
  Lines         388      323      -65     
==========================================
- Hits          343      289      -54     
+ Misses         45       34      -11     
Flag Coverage Δ
unittests 89.47% <96.62%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HCIToolbox.jl 100.00% <ø> (ø)
src/angles.jl 100.00% <ø> (ø)
src/masking.jl 48.93% <79.16%> (+2.26%) ⬆️
src/geometry/annulus.jl 96.87% <100.00%> (ø)
src/geometry/geometry.jl 100.00% <100.00%> (ø)
src/geometry/multiannulus.jl 95.31% <100.00%> (-1.57%) ⬇️
src/inject.jl 100.00% <100.00%> (+10.20%) ⬆️
src/morphology.jl 97.53% <100.00%> (ø)
src/scaling.jl 89.74% <100.00%> (+1.06%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341aa9f...627706b. Read the comment docs.

@mileslucas mileslucas merged commit 978f2f0 into main Feb 7, 2022
@mileslucas mileslucas deleted the ml/orient branch February 7, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant