Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial for SimpleMotion creation and simulation #387

Merged
merged 58 commits into from
Jun 3, 2024

Conversation

pvillacorta
Copy link
Collaborator

@pvillacorta pvillacorta commented May 1, 2024

@pvillacorta pvillacorta changed the title Documentation: Tutorial on SimpleMotion creation and simulation Documentation: Tutorial for SimpleMotion creation and simulation May 1, 2024
@pvillacorta pvillacorta marked this pull request as ready for review May 1, 2024 09:39
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.47%. Comparing base (b3d6cd4) to head (f6074ec).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   89.89%   89.47%   -0.42%     
==========================================
  Files          43       43              
  Lines        2730     2728       -2     
==========================================
- Hits         2454     2441      -13     
- Misses        276      287      +11     
Flag Coverage Δ
base 86.42% <100.00%> (ø)
core 86.93% <ø> (ø)
files 93.70% <ø> (ø)
komamri 93.96% <ø> (ø)
plots 89.64% <33.33%> (-3.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
KomaMRIBase/src/datatypes/Phantom.jl 84.86% <ø> (ø)
...se/src/datatypes/phantom/motion/ArbitraryMotion.jl 98.21% <100.00%> (ø)
...IBase/src/datatypes/phantom/motion/SimpleMotion.jl 66.66% <ø> (ø)
...datatypes/phantom/motion/simplemotion/HeartBeat.jl 92.85% <ø> (ø)
...s/phantom/motion/simplemotion/PeriodicHeartBeat.jl 0.00% <ø> (ø)
...es/phantom/motion/simplemotion/PeriodicRotation.jl 90.47% <100.00%> (ø)
.../datatypes/phantom/motion/simplemotion/Rotation.jl 90.47% <100.00%> (ø)
...tatypes/phantom/motion/simplemotion/Translation.jl 81.81% <ø> (ø)
KomaMRIPlots/src/ui/DisplayFunctions.jl 90.47% <33.33%> (-3.54%) ⬇️

@pvillacorta pvillacorta requested a review from cncastillo as a code owner May 1, 2024 11:50
KomaMRIPlots/src/ui/DisplayFunctions.jl Outdated Show resolved Hide resolved
KomaMRIPlots/src/ui/DisplayFunctions.jl Outdated Show resolved Hide resolved
Copy link
Member

@cncastillo cncastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes, you can change the first example to the translation, and then you focus the second section on the "motion-corrected reconstruction" (not just corrected). Also when the simple motion types are explained, some references to the API definitions of Translation, Rotation, etc could be added.

@pvillacorta
Copy link
Collaborator Author

@cncastillo you mean removing the rotation section? So first section would be translation and second would be motion-corrected simulation?

@cncastillo
Copy link
Member

cncastillo commented May 30, 2024

@cncastillo you mean removing the rotation section? So first section would be translation and second would be motion-corrected simulation?

More like removing the new translation section, and modify the current one with the mentioned modifications:

  • Use "motion-corrected reconstruction" (not just corrected)
  • Change first section to use a Translation
  • Also when the simple motion types are explained, some references to the API definitions of Translation, Rotation, etc could be added
  • Limit max-height of images in docstring to max-height: 300px;

Copy link
Member

@cncastillo cncastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! when these are fixed we can merge.

docs/src/reference/2-koma-base.md Outdated Show resolved Hide resolved
examples/3.tutorials/lit-05-SimpleMotion.jl Outdated Show resolved Hide resolved
examples/3.tutorials/lit-05-SimpleMotion.jl Outdated Show resolved Hide resolved
examples/3.tutorials/lit-05-SimpleMotion.jl Outdated Show resolved Hide resolved
examples/3.tutorials/lit-05-SimpleMotion.jl Outdated Show resolved Hide resolved
examples/3.tutorials/lit-05-SimpleMotion.jl Outdated Show resolved Hide resolved
examples/3.tutorials/lit-05-SimpleMotion.jl Outdated Show resolved Hide resolved
KomaMRIBase/src/datatypes/phantom/motion/SimpleMotion.jl Outdated Show resolved Hide resolved
@cncastillo cncastillo merged commit 93b4c90 into master Jun 3, 2024
19 checks passed
@cncastillo cncastillo deleted the docs-simplemotion branch June 3, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements to docs., it also triggers doc preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants