-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial for SimpleMotion creation and simulation #387
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 89.89% 89.47% -0.42%
==========================================
Files 43 43
Lines 2730 2728 -2
==========================================
- Hits 2454 2441 -13
- Misses 276 287 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes, you can change the first example to the translation, and then you focus the second section on the "motion-corrected reconstruction" (not just corrected). Also when the simple motion types are explained, some references to the API definitions of Translation, Rotation, etc could be added.
@cncastillo you mean removing the rotation section? So first section would be translation and second would be motion-corrected simulation? |
More like removing the new translation section, and modify the current one with the mentioned modifications:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! when these are fixed we can merge.
Co-authored-by: Carlos Castillo Passi <[email protected]>
Co-authored-by: Carlos Castillo Passi <[email protected]>
Co-authored-by: Carlos Castillo Passi <[email protected]>
Co-authored-by: Carlos Castillo Passi <[email protected]>
Co-authored-by: Carlos Castillo Passi <[email protected]>
Co-authored-by: Carlos Castillo Passi <[email protected]>
https://juliahealth.org/KomaMRI.jl/previews/PR387/