Only grow buffer exponentially when marked #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is a logical bug somewhere else in the code. |
|
Fixed by #130 . @Drvi , can you confirm that this fix stops the unneeded buffer growth in your use case? It does not resize the buffer using the following test code: julia> open(GzipDecompressorStream, PATH_TO_LARGE_GZIP_FILE) do io
while true
buf = zeros(UInt8, 1024)
iszero(readbytes!(io, buf, 1024)) && break
end
endYet it still grows buffers exponentially when needed. |
|
@jakobnissen Yes, your PR solved my problem! Thanks so much for a quick, proper fix:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on an a custom streaming object for JuliaServices/CloudStore.jl#24, I noticed that when decoding a 500MB gziped file, the buffers used by TranscodingStreams grow to unreasonable size. Here are some stats as captured inside the
fillbufferfunction (length, buffersize, marginsize):So to decompress a 500MB file, we end up allocating 870MB of buffers which is wasteful and very slow for our prefetched downloading stream. With this change, the buffers don't change in size while decompressing the same file.
IIUC, #121 was introduced to help with cases where significant part of the buffer is marked, so I restricted the growing behavior to be proportional to size of the marked region.
CC: @jakobnissen @quinnj