Do not reserve exponentially growing margin #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fde7eea, buffers were changed to growing exponentially by calling `makemargin!(buf, X)` with an exponentially growing X. However, this is not the right way of solving the problem. Indeed, only a single byte of margin is necessary when removing already-used data from the buffer. Requiring exponentially increasing margins forces unneeded buffer resizes. Instead, `makemargin!` itself should exponentially increase buffersize when it finds that it can't make enough margin, and the callers of `makemargin!` should request only 1 byte of space, as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fde7eea, buffers were changed to growing exponentially by calling
makemargin!(buf, X)with an exponentially growing X. However, this is not the right way of solving the problem. Indeed, only a single byte of margin is necessary when removing already-used data from the buffer. Requiring exponentially increasing margins forces unneeded buffer resizes.Instead,
makemargin!itself should exponentially increase buffersize when it finds that it can't make enough margin, and the callers ofmakemargin!should request only 1 byte of space, as before.