-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inner function signatures cannot depend on static parameters #15068
Comments
Yes, this affects at least NLsolve and SimJulia (see #13412 (comment)). I think I'll be able to fix this before 0.5-final. |
Lora also depends on this getting fixed as far as v0.5 is concerned. |
@Scidom is this something that would block Lora from running on 0.5.0 until fixed in 0.5.1, or could you work around this somehow? If the former, please scream loudly now and try to convince the core team to make this a release blocking issue for 0.5.0 (my selfish reason for this is that I won't be able to update to julia 0.5 unless Lora runs on it). @tkelman [as the (un?)official release manager]. |
You don't need to ping me personally on this kind of thing, but thanks for the bump, a few more of these would be valuable. If you want to keep track of them in a single place, one comment per person on #17418 with a checklist of "issues/PR's I would personally like someone to look at before the release" would be a good idea. Everyone is likely to have their own such list, if issue numbers have already been linked from anyone else's comment there then just a +1 reaction (click the smiley, don't leave a comment for +1's) is most appropriate. |
Unfortunately, @JeffBezanson is the person who would fix this and he just went on vacation, so I think it's a bit too late for this to make it into the 0.5.0 release. |
there is logic present to also handle all locals, but this causes some broken toplevel lowering to fail (notably, some gensym locals are getting pulled into global scope and some toplevel scopes are incorrectly identified as local scope) fix #15068
there is logic present to also handle all locals, but this causes some broken toplevel lowering to fail (notably, some gensym locals are getting pulled into global scope and some toplevel scopes are incorrectly identified as local scope) fix #15068
there is logic present to also handle all locals, but this causes some broken toplevel lowering to fail (notably, some gensym locals are getting pulled into global scope and some toplevel scopes are incorrectly identified as local scope) fix #15068
there is logic present to also handle all locals, but this causes some broken toplevel lowering to fail (notably, some gensym locals are getting pulled into global scope and some toplevel scopes are incorrectly identified as local scope) fix #15068
@davidanthoff I just saw your message above, I can confirm that this now is not stopping Lora from running on Julia v0.5 anymore. In fact, I tried to update Lora today to work with v0.5, let me know if you have any issues. |
there is logic present to also handle all locals, but this causes some broken toplevel lowering to fail (notably, some gensym locals are getting pulled into global scope and some toplevel scopes are incorrectly identified as local scope) fix JuliaLang#15068
Defining
gives "LoadError: UndefVarError: T not defined", but evidently it is. See https://groups.google.com/forum/#!topic/julia-users/Fvfmvtq8xVs and #13412 (comment)
The text was updated successfully, but these errors were encountered: