inner function signature using sparams #17487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # return (subf(one(T), x * im), subf(unsigned(one(T)))) | ||
| #end | ||
| #@test local_innersig(Int32(2)) == ((Int32(2), Int32(1), Int32(2)im), (Int32(2), UInt32(1))) | ||
| #@test local_innersig(Int64(3)) == ((Int64(3), Int64(1), Int64(3)im), (Int64(3), UInt64(1))) |
There was a problem hiding this comment.
the function definition lowering comes out wrong, not the test
|
Re: added and removed milestone -- ignore, was unintentional. |
|
@JeffBezanson review thoughts? |
| `(thunk | ||
| (define (type-for-closure-parameterized name P names fields types super) | ||
| (let ((n (length P))) | ||
| `((thunk |
There was a problem hiding this comment.
I don't think this should return a list; needing a list of the expression is only an artifact of how this is used.
There was a problem hiding this comment.
It also doesn't need to return a lambda, just a couple of statements, but lowering handled that wrong
|
A few minor comments, but looks basically good. |
there is logic present to also handle all locals, but this causes some broken toplevel lowering to fail (notably, some gensym locals are getting pulled into global scope and some toplevel scopes are incorrectly identified as local scope) fix #15068
|
Interesting crash on 32-bit travis here. |
|
helped by #17516 probably? |
|
Should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows an inner function signature to reference sparams of the caller
fix #15068