Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveUtils crashed on CI #45310

Closed
Keno opened this issue May 14, 2022 · 5 comments · Fixed by #46297
Closed

InteractiveUtils crashed on CI #45310

Keno opened this issue May 14, 2022 · 5 comments · Fixed by #46297
Labels
ci Continuous integration

Comments

@Keno
Copy link
Member

Keno commented May 14, 2022

https://buildkite.com/julialang/julia-master/builds/11964#6454de35-bceb-4fdb-b92c-6f6acd92e377

An rr trace is available.

@DilumAluthge
Copy link
Member

@Keno Is that the right link? That link doesn't have an rr trace attached, because rr failed to cleanup within 1 hour, so we SIGKILLed it.

@Keno
Copy link
Member Author

Keno commented May 16, 2022

@Keno Is that the right link? That link doesn't have an rr trace attached, because rr failed to cleanup within 1 hour, so we SIGKILLed it.

Oh, you are correct. My bad. Do we know what that happens?

@DilumAluthge
Copy link
Member

Yeah I have no idea what the cause is. It's not uncommon to see.

Basically it means that rr didn't exit within 60 minutes after we sent it SIGTERM.

@Keno
Copy link
Member Author

Keno commented May 16, 2022

Can we see if we can reproduce this locally. Basically throw unsafe_load(Ptr{Int}(1)) in a few places in the tests and see if we can get this to happen? We may need to more aggressively send SIGTERM to the entire process tree rather than just the toplevel rr.

@vtjnash vtjnash added the ci Continuous integration label Jun 17, 2022
@vtjnash
Copy link
Member

vtjnash commented Aug 9, 2022

This was introduced by #44548, which was merged earlier that week, and changed the Julia definition of struct without changing the C representation. Sometimes that means we do an OOB value and use that to do an OOB read on an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants