make the .line and inlined_at fields in LineInfoNode Int32
#44548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/lineinfo_size
branch
from
c526a23 to
5d9a2f1
Compare
KristofferC
force-pushed
the
kc/lineinfo_size
branch
from
5d9a2f1 to
43f3db4
Compare
| @@ -1112,7 +1112,8 @@ function deserialize(s::AbstractSerializer, ::Type{Core.LineInfoNode}) | |||
| method = mod | |||
| mod = Main | |||
| end | |||
| return Core.LineInfoNode(mod, method, deserialize(s)::Symbol, deserialize(s)::Int, deserialize(s)::Int) | |||
| T = format_version(s) >= 19 ? Int32 : Int | |||
| return Core.LineInfoNode(mod, method, deserialize(s)::Symbol, Int32(deserialize(s)::T), Int32(deserialize(s)::T)) | |||
There was a problem hiding this comment.
I would just allow either type here, so deserializing works even without a header specifying the version.
There was a problem hiding this comment.
Is bd6615e what you meant?
There was a problem hiding this comment.
We can add a ::Union{Int32, Int} typeassert; the compiler will split that very nicely.
fredrikekre
pushed a commit
that referenced
this pull request
Aug 10, 2022
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of
LineInfoNodefrom 40 bytes to 32. UsingInt32for line numbers is also already done in various other places (as can be seen by the diff in the PR) so this makes things more consistent as well.