ppc64 build cleanups and updated openblas for power #18301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViralBShah
added
system:powerpc
| @@ -1,2 +1,7 @@ | |||
| ifneq (,$(filter $(ARCH), powerpc64le ppc64le)) | |||
| OPENBLAS_BRANCH=develop | |||
There was a problem hiding this comment.
Not yet, but I believe 0.2.19 is imminent soon - a day or two. Given that the rc4 may need some more time, let's wait and see if we can use a tagged version here.
There was a problem hiding this comment.
you'd need to add checksums too
|
This should be good to go now. OpenBLAS updated to v0.2.19 for Power. |
|
Build failures are mostly unrelated. |
|
@tkelman Can we get this one into 0.5-rc4? Thanks. |
ViralBShah
changed the title
|
Yes. I'll add it. Don't need to ping me again, the label is enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for both ppc64le and powerpc64le as the arch names consistently across the build.
Use a newer openblas for power8.