Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64 build cleanups and updated openblas for power #18301

Merged
merged 2 commits into from
Sep 1, 2016
Merged

ppc64 build cleanups and updated openblas for power #18301

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b0589
ppc64 build cleanups
ViralBShah Aug 31, 2016
857469d
Update OpenBLAS to v0.2.19 for Power8.
ViralBShah Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deps/llvm.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,9 @@ LLVM_CMAKE += -DLLDB_DISABLE_PYTHON=ON
endif # LLDB_DISABLE_PYTHON
endif # BUILD_LLDB

ifeq ($(ARCH), ppc64)
ifneq (,$(filter $(ARCH), powerpc64le ppc64le))
LLVM_CXXFLAGS += -mminimal-toc
endif # ARCH == ppc64
endif

# LLVM bug #24157
ifeq ($(USE_LLVM_SHLIB),1)
Expand Down
5 changes: 5 additions & 0 deletions deps/openblas.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
ifneq (,$(filter $(ARCH), powerpc64le ppc64le))
OPENBLAS_BRANCH=develop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a tag for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, but I believe 0.2.19 is imminent soon - a day or two. Given that the rc4 may need some more time, let's wait and see if we can use a tagged version here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'd need to add checksums too

OPENBLAS_SHA1=515bc56ea92cf7afa6c8316eb0f760439944300b
else
OPENBLAS_BRANCH=v0.2.18
OPENBLAS_SHA1=12ab1804b6ebcd38b26960d65d254314d8bc33d6
endif
2 changes: 1 addition & 1 deletion deps/unwind.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ endif
#todo: libunwind tests are known to fail, so they aren't run
$(LIBUNWIND_TARGET_OBJ): $(LIBUNWIND_TARGET_SOURCE)
$(call make-install,libunwind-$(UNWIND_VER),)
ifeq ($(ARCH), ppc64)
ifneq (,$(filter $(ARCH), powerpc64le ppc64le))
@# workaround for configure script bug
mv $(build_prefix)/lib64/libunwind*.a $(build_libdir)
endif
Expand Down