Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

RFC: various fixes for the latest MOI #5

Merged
merged 13 commits into from
May 1, 2018
Merged

RFC: various fixes for the latest MOI #5

merged 13 commits into from
May 1, 2018

Conversation

odow
Copy link
Member

@odow odow commented Apr 27, 2018 •
edited
Loading

  • if two bound constraints exist, then the reduced cost of the variable is only non-zero on the bound that is binding.
  • adds model name
  • adds variable names
  • adds constraint names
  • sorts indexes by .value so that the list return is ordered by creation time
  • adds functions for quadratic constraint primal/dual solutions
  • documents the interface

Constraint names currently implemented via a Dict{String, Any} which is pretty bad. But leaving until it is demonstrated as a performance problem.

  • Once this is merged we can move the repo to MOI.

@odow odow mentioned this pull request Apr 27, 2018
Merged
12 tasks
@odow odow requested a review from joaquimg April 28, 2018 01:00
@odow odow mentioned this pull request Apr 28, 2018
Merged
14 tasks
@odow odow changed the title WIP: fixes to get Gurobi tests passing WIP: various fixes for the latest MOI Apr 28, 2018
@odow
Copy link
Member Author

odow commented Apr 28, 2018

Reminder for me: add a SingleVariable objective (and test to MOI).

odow
odow commented Apr 28, 2018
View reviewed changes
src/ref.jl Outdated
"""
function lqs_delsos!(m::LinQuadOptimizer, start_idx, end_idx) end

# TODO(@joaquim): what is sertype. Why not a function?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquimg

src/ref.jl Outdated
"""
function lqs_chgobjsen!(m::LinQuadOptimizer, sense) end

#TODO(@joaquimg): why is this not in-place?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquimg

src/ref.jl Outdated
function lqs_getobjval(m::LinQuadOptimizer) end

# TODO(@joaquimg): what is this?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquimg

@odow
Copy link
Member Author

odow commented Apr 29, 2018 •
edited
Loading

The interface could probably do with a big clean up.

Remove the lqs_ prefix (#4), remove some of the redundant methods, and make the method names more explanatory.

@joaquimg if you agree, I'd like to merge this as is, then work on another PR implmenting the above changes.

@odow odow changed the title WIP: various fixes for the latest MOI RFC: various fixes for the latest MOI Apr 29, 2018
@odow
Copy link
Member Author

odow commented May 1, 2018

I'm merging this as is. If @joaquimg has any issues they can be addressed in a new PR

@odow odow merged commit 8bb6e7a into master May 1, 2018
@odow odow deleted the oscar branch May 1, 2018 01:20
@joaquimg
Copy link
Member

joaquimg commented May 2, 2018

@odow I was out, the PR ir great. YES lets work on the renaming

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaquimg joaquimg Awaiting requested review from joaquimg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @joaquimg