Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: TranscodingStreams v0.9.11 #75395

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 3bb67fe8-82b1-5028-8e26-92a6c54297fa
Repo: https://github.com/JuliaIO/TranscodingStreams.jl.git
Tree: 94f38103c984f89cf77c402f2a68dbd870f8165f

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in JuliaIO/TranscodingStreams.jl Jan 9, 2023
In fde7eea, buffers were changed to growing exponentially by calling
`makemargin!(buf, X)` with an exponentially growing X. However, this is not the
right way of solving the problem. Indeed, only a single byte of margin is
necessary when removing already-used data from the buffer. Requiring
exponentially increasing margins forces unneeded buffer resizes.

Instead, `makemargin!` itself should exponentially increase buffersize when it
finds that it can't make enough margin, and the callers of `makemargin!` should
request only 1 byte of space, as before.
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch January 9, 2023 16:03 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit 2a4e6d4 into master Jan 9, 2023
@JuliaTagBot JuliaTagBot deleted the registrator/transcodingstreams/3bb67fe8/v0.9.11 branch January 9, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants