Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering package from subdirectory fails when using web UI #343

Open
racinmat opened this issue Jul 16, 2021 · 3 comments
Open

Registering package from subdirectory fails when using web UI #343

racinmat opened this issue Jul 16, 2021 · 3 comments

Comments

@racinmat
Copy link
Contributor

As part of MWE for this bug, I tried to register https://github.com/racinmat/TestPackageMonorepo.jl/tree/master/TestPackageSubDir1
(filling https://github.com/racinmat/TestPackageMonorepo.jl.git to Package URL
, GitHub to Server Type and TestPackageSubDir1 to Directory).
It fails to register and says The sub-directory TestPackageSubDir1 does not exist in this repository.

My suspicion is the bug is https://github.com/JuliaRegistries/Registrator.jl/blob/master/src/webui/gitutils.jl#L168 because git clone --bare clones the bare git metadata and thus the directory contains hooks, info, objects etc. but not the actual subdirectory, because that is available only when --bare is not used.

I think this bug occurred during 1c35395 when the checking for isdir(joinpath(dest, subdir)) wasn't modified accordingly.
racinmat referenced this issue Jul 16, 2021
@nkottary
Do a bare clone when getting tree SHA (#340)
1c35395 
Doing a bare git clone:
* Makes all the remote branches local
* Gives us all the tags

Its also slightly faster than just clone.
This will fix #339 and also correctly fixes what #335 tried to fix
@nkottary nkottary mentioned this issue Jul 17, 2021
Merged
nkottary added a commit that referenced this issue Jul 18, 2021
@nkottary
Remove isdir check for sub-directory in gettreesha (#344)
8eeb7eb 
See #343 and 1c35395
@racinmat
Copy link
Contributor Author

Fixed by #344

@racinmat
Copy link
Contributor Author

It seems the fixed version is not deployed, https://juliahub.com/ui/Registrator still throws the error.

@racinmat racinmat reopened this Aug 11, 2021
@racinmat
Copy link
Contributor Author

@nkottary any ETA on deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@racinmat