Enable ZonedDateTime to parse its own string representation #483
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit makes it unnecessary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 92.79% 92.70% -0.09%
==========================================
Files 39 38 -1
Lines 1818 1838 +20
==========================================
+ Hits 1687 1704 +17
- Misses 131 134 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #470 in a way that formally preserves backwards compatibility of
TimeZones.The first commit is what solves the issue. The second commit is optional, but given that
Dates.default_format(::Type{ZonedDateTime})is no longer used in theTimeZonespackage, notpublicand not documented anywhere, I feel that it would be most correct to delete it as this would still formally preserve backwards compatibility.