-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZonedDateTime can parse its own string representation #483
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
246b064
ZonedDateTime can parse its own String output (#470)
GHTaarn 8e682ed
Removed Dates.default_format(::Type{ZonedDateTime})
GHTaarn 0a067de
Handle >4 digit year in ZonedDateTime(::AbstractString)
GHTaarn c885cab
Call `init_dates_extension` once from top-level
omus b5814fa
Ensure parsing finds a literal `T`
omus 6dd1df1
Rename `NoMillisecondFormat` to `ISOZonedDateTimeNoMillisecondFormat`
omus 9e413e2
Add exhaustive self-parse tests
omus 68a90ec
Treat `parse` as primary parsing functions
omus 3e4ead3
Improve parsing heuristic
omus 8b42414
Deprecate `Dates.default_format`
omus 4f6add7
fixup! Deprecate `Dates.default_format`
omus c578c3a
Merge branch 'master' into self_parse
omus 1817629
Docstrings for ZonedDateTime(::AbstractString,...)
GHTaarn e43de35
Extra dosctring for Dates.DateFormat
GHTaarn f66c6df
More self-parse tests
GHTaarn b51e903
Documentation update
omus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
@testset "default format" begin | ||
@test Dates.default_format(ZonedDateTime) === TimeZones.ISOZonedDateTimeFormat | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you said this isn't documented anywhere so it's technically not public. I think it's safest to deprecate this in the off chance anyone is using this.