Fixes #429 - "toMatchGraphObjectSchema" fails when multiple classes s…

…hare same "enum" property

packages/integration-sdk-testing/src/jest.ts

@@ -113,6 +113,46 @@ function dedupSchemaPropertyTypes(
   };
 }
 
+/**
+ * It's possible that two classes contain the same property name and both have
+ * "enum" values in the schema.
+ *
+ * For example, `Host` and `Device` both contain a `platform` property that
+ * contain enum values.
+ *
+ * See here:
+ *
+ * - https://github.com/JupiterOne/data-model/blob/master/src/schemas/Host.json#L75
+ * - https://github.com/JupiterOne/data-model/blob/master/src/schemas/Device.json#L58
+ *
+ * @param schema
+ */
+function dedupSchemaEnumValues(schema: GraphObjectSchema): GraphObjectSchema {
+  if (!schema.properties) {
+    return schema;
+  }
+
+  const newProperties: Record<string, any> = {};
+
+  for (const propertyName in schema.properties) {
+    const property = schema.properties[propertyName];
+
+    if (property.enum) {
+      newProperties[propertyName] = {
+        ...property,
+        enum: Array.from(new Set(property.enum)),
+      };
+    } else {
+      newProperties[propertyName] = property;
+    }
+  }
+
+  return {
+    ...schema,
+    properties: newProperties,
+  };
+}
+
 function generateGraphObjectSchemaFromDataModelSchemas(
   schemas: GraphObjectSchema[],
 ) {
@@ -155,9 +195,11 @@ function generateGraphObjectSchemaFromDataModelSchemas(
     newSchemas.push(schema);
   }
 
-  return dedupSchemaRequiredPropertySchema(
-    dedupSchemaPropertyTypes(deepmerge.all(newSchemas)),
-  );
+  let resultSchema = dedupSchemaPropertyTypes(deepmerge.all(newSchemas));
+  resultSchema = dedupSchemaRequiredPropertySchema(resultSchema);
+  resultSchema = dedupSchemaEnumValues(resultSchema);
+
+  return resultSchema;
 }
 
 function graphObjectClassToSchemaRef(_class: string) {

packages/integration-sdk/CHANGELOG.md

@@ -9,6 +9,12 @@ and this project adheres to
 
 ## Unreleased
 
+### Fixed
+
+- [#429](https://github.com/JupiterOne/sdk/issues/429) - fixed
+  `toMatchGraphObjectSchema` failure when multiple classes share same `enum`
+  property name.
+
 ## 5.8.1 - 2021-03-03
 
 ### Fixed