Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"toMatchGraphObjectSchema" fails when multiple classes share same "enum" property #429

Closed
austinkelleher opened this issue Mar 4, 2021 · 0 comments
Closed

"toMatchGraphObjectSchema" fails when multiple classes share same "enum" property #429

austinkelleher opened this issue Mar 4, 2021 · 0 comments
Assignees
@austinkelleher
Labels
bug Something isn't working

Comments

@austinkelleher
Copy link
Contributor

austinkelleher commented Mar 4, 2021 •
edited
Loading

Description

It's possible that two classes contain the same property name and both have "enum" values in the schema. For example, Host and Device both contain a platform property that contain enum values.

See here:

We should merge the two sets of enum values in this case.

Sample error

schema is invalid: data.properties['platform'].enum should NOT have duplicate items (items ## 7 and 15 are identical)
@austinkelleher austinkelleher added the bug Something isn't working label Mar 4, 2021
@austinkelleher austinkelleher self-assigned this Mar 4, 2021
austinkelleher added a commit that referenced this issue Mar 4, 2021
@austinkelleher
Add failing test for #429
967b572
austinkelleher added a commit that referenced this issue Mar 4, 2021
@austinkelleher
Merge pull request #430 from JupiterOne/429-toMatchGraphObjectSchema-…
ed0b4d8 
…enum

Fixes #429 - "toMatchGraphObjectSchema" fails when multiple classes share same "enum" property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austinkelleher austinkelleher

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@austinkelleher