Fixes #301 - StepRelationshipMetadata in Step should require #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RelationshipClass from @jupiterone/data-model
ndowmon
reviewed
Aug 24, 2020
|
@ndowmon Good question. This is a breaking change. We have not released the new version of the SDK yet. The original metadata changes haven't been released. |
ndowmon
approved these changes
Aug 24, 2020
|
@austinkelleher Thanks for the clarification :) |
|
That is a good question @ndowmon. I now wonder if we should be taking this approach. 🤔 Are there alternative ways to ensure the data is generated with valid relationship classes? Perhaps it should be in the schema alone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelationshipClass from @jupiterone/data-model