Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepRelationshipMetadata in Step should require RelationshipClass from @jupiterone/data-model #301

Closed
austinkelleher opened this issue Aug 24, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@austinkelleher
Copy link
Contributor

Related: #285

We recently introduced metadata in Step, which is used to auto-generate documentation. The StepRelationshipMetadata currently has a _class property with the type string. We should change that to be RelationshipClass from @jupiterone/data-model. See here: https://github.com/JupiterOne/sdk/blob/master/packages/integration-sdk-core/src/types/step.ts#L83

Old:

export interface StepRelationshipMetadata extends StepGraphObjectMetadata {
  _class: string;
  sourceType: string;
  targetType: string;
}

New:

import { RelationshipClass } from '@jupiterone/data-model';

export interface StepRelationshipMetadata extends StepGraphObjectMetadata {
  _class: RelationshipClass;
  sourceType: string;
  targetType: string;
}
@austinkelleher austinkelleher added the enhancement New feature or request label Aug 24, 2020
@austinkelleher austinkelleher self-assigned this Aug 24, 2020
austinkelleher added a commit that referenced this issue Aug 24, 2020
Fixes #301 - StepRelationshipMetadata in Step should require
ndowmon pushed a commit that referenced this issue Aug 26, 2020
Fixes #301 - Register inputEntities & inputRelationships in mockJobState
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant