Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text dotted underline #2045

Merged
merged 5 commits into from
Jan 30, 2025
Merged

fix: text dotted underline #2045

merged 5 commits into from
Jan 30, 2025

Conversation

pixelflips
Copy link
Member

Description

New text style that adds a dotted underline.
Adds a new class and tokens that can be used to accomplish dotted underline on text elements.

Screenshots

Screenshot 2025-01-29 at 3 02 33 PM

Testing in sage-lib

  • Navigate to docs site or storybook
  • Add class to a text element
  • Verify dotted border shows

Testing in kajabi-products

  1. (LOW) Adds new class for text underline dotted styling. No effect on KP expected.

Related

https://kajabi.atlassian.net/browse/DSS-1247

@pixelflips pixelflips self-assigned this Jan 30, 2025
@pixelflips pixelflips requested a review from a team January 30, 2025 00:31
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@anechol anechol requested a review from a team January 30, 2025 16:17
@pixelflips pixelflips merged commit ffd3e3f into develop Jan 30, 2025
7 checks passed
ju-Skinner added a commit that referenced this pull request Jan 31, 2025
* style: update Font Family's to match the system installed font name (#2038)

Co-authored-by: Julian Skinner <[email protected]>

* style: add border to only catalog item child (#2040)

* style: update rtl positioning (#2043)

* fix: remove button role from react modal (#2044)

* fix: remove rtl logical wrapper (#2041)

* fix: add text dotted underline (#2045)

* fix: add new dotted underline classes

* style: add dotted underline styles

* docs: update docs to include dotted underline

* fix: hello linter my old friend

* style: correct underline dotted styles for better safari support

* style: add selector for icon-only buttons to not rely on icon name (#2046)

* style: add selector for icon-only buttons to not rely on icon name

* style: correct lint error

---------

Co-authored-by: Julian Skinner <[email protected]>
Co-authored-by: Quinton Jason <[email protected]>
Co-authored-by: Phillip Lovelace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants