style: add selector for icon-only buttons to not rely on icon name #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anechol
approved these changes
Jan 30, 2025
ju-Skinner
added a commit
that referenced
this pull request
Jan 31, 2025
* style: update Font Family's to match the system installed font name (#2038) Co-authored-by: Julian Skinner <[email protected]> * style: add border to only catalog item child (#2040) * style: update rtl positioning (#2043) * fix: remove button role from react modal (#2044) * fix: remove rtl logical wrapper (#2041) * fix: add text dotted underline (#2045) * fix: add new dotted underline classes * style: add dotted underline styles * docs: update docs to include dotted underline * fix: hello linter my old friend * style: correct underline dotted styles for better safari support * style: add selector for icon-only buttons to not rely on icon name (#2046) * style: add selector for icon-only buttons to not rely on icon name * style: correct lint error --------- Co-authored-by: Julian Skinner <[email protected]> Co-authored-by: Quinton Jason <[email protected]> Co-authored-by: Phillip Lovelace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we no longer update the icon list in Sage, this has caused a padding issue on the icon-only buttons when new icons are added to the system.
Currently, the generated class names include the icon name. We should adjust the style selector so the icon name is unnecessary since we no longer update the list of icons in Sage.
This PR adjusts the CSS selector so the icon name is not required.
Screenshots
Testing in
sage-libsage-btn--icon-only-file-search)Testing in
kajabi-productsRelated
https://kajabi.atlassian.net/browse/DSS-1249