Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt quarkus-full-microprofile based tests to work with Quarkus >= 3.6.0 #225

Closed
zakkak opened this issue Nov 21, 2023 · 2 comments · Fixed by #227
Closed

Adapt quarkus-full-microprofile based tests to work with Quarkus >= 3.6.0 #225

zakkak opened this issue Nov 21, 2023 · 2 comments · Fixed by #227
Assignees
Labels
bug Something isn't working

Comments

@zakkak
Copy link
Collaborator

zakkak commented Nov 21, 2023

Starting with Quarkus 3.6.0 quarkus-smallrye-opentracing is no longer a core extension. quarkus-full-microprofile depends on it and thus fails with Quarkus >= 3.6.0 (as observed in #223)

#224 disabled quarkus-full-microprofile based tests for Quarkus >= 3.6.0, which comes with the big drawback that we are no longer running 3 important tests.

@jerboaa suggested in #223 (comment):

how about we produce a profile that activates based on the quarkus version and adds the quarkiverse dependency for later versions?

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 21, 2023

Regarding @jerboaa 's suggestion:

One potential issue I see with that is that our test will then depend on a quarkiverse dependency which I expect to be tricky when testing Quarkus main.

Since I am not familiar with the code nor with the testing goals of it I will leave that to @Karm. Perhaps we can completely replace it or drop the smallrye-opentracing dependency.

@Karm
Copy link
Owner

Karm commented Nov 21, 2023

I will create a patch. This is IMHO connected to MicroProfile specification that is getting rid of a one monitoring API in favor of another, i.e. we get rid of Jaeger things in favor of OpenTelemetry for good.

We will need .patch so as older Qurkus versions keep working and we can have the same app. Given the simplicity of the app, I think it's still more manageable than having a separate test app in apps dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants