Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary work around: Disable quarkus-full-microprofile dependent tests #224

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Nov 20, 2023

Works around #223 to get CI passing till it gets fixed.

One major drawback, other than the obvious one of skipping three good tests in Quarkus >= 3.6.0 is that we skip them for any SNAPSHOT build as well even for Quarkus < 3.6.0.

Works around
Karm#223 to get CI
passing till it gets fixed.
@zakkak zakkak requested review from jerboaa and Karm November 20, 2023 19:40
@zakkak zakkak changed the title Disable quarkus-full-microprofile dependent tests Temporary work around: Disable quarkus-full-microprofile dependent tests Nov 20, 2023
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it, but it's better than having those noisy CI runs. Could you please file an issue which tracks fixing this properly?

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 21, 2023

Could you please file an issue which tracks fixing this properly?

Done #225

@zakkak zakkak merged commit 387122d into Karm:master Nov 21, 2023
@zakkak zakkak deleted the 2023-11-20-workaround-missing-smallrye-opentracing-dependency branch November 21, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants