Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullMicroprofile ported to new tracing API, MP6+ Q3.6+ #227

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

Karm
Copy link
Owner

@Karm Karm commented Nov 25, 2023

Fixes #225

$ mvn clean verify -Ptestsuite 
-Dtest=RuntimesSmokeTest#quarkusFullMicroProfile,DebugSymbolsTest#debugSymbolsQuarkus,PerfCheckTest#testQuarkusFullMicroProfile 
-Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-21 
-DincludeTags=runtimes,reproducers,perfcheck -Dquarkus.version=3.6.0 | tee log.log 

passes now.

@Karm Karm requested review from zakkak and jerboaa November 25, 2023 09:50
@@ -1,6 +1,6 @@
linux.time.to.first.ok.request.threshold.ms=300
linux.RSS.threshold.kB=120000
linux.executable.size.threshold.kB=73500
linux.executable.size.threshold.kB=79000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make these Quarkus/Mandrel specific.

My understanding is that you are increasing the threshold for Quarkus 3.6, but this will make us miss increases happening in 3.2 for instance.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak Yes. The increase is caused by OpenTelemetry being a much bigger library than OpenTracing apparently.

The "design" of the property files did not take into account the Q versions.

We can start having some per-quarkus-version property files. Perhaps per Mandrel major.minor too.

Non-quarkus apps would have just the Mandrel major.minor?

Wondering how to make it nice and tidy without inflating the logic too much.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-quarkus apps would have just the Mandrel major.minor?

Yes

Wondering how to make it nice and tidy without inflating the logic too much.

I need something similar in quarkusio/quarkus#36108 and I was thinking about using a directory structure like <quarkus-version>/<mandrel-version>/threshold.properties. WDYT?

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the threshold bumps which we should better address in another PR since it's a general issue not specific to this PR.

Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with getting this in and do the proper threshold refactoring fix in a follow-up.

@zakkak zakkak merged commit 8a5e272 into master Nov 27, 2023
@zakkak zakkak deleted the issues-225 branch November 27, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt quarkus-full-microprofile based tests to work with Quarkus >= 3.6.0
3 participants