-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FullMicroprofile ported to new tracing API, MP6+ Q3.6+ #227
Conversation
@@ -1,6 +1,6 @@ | |||
linux.time.to.first.ok.request.threshold.ms=300 | |||
linux.RSS.threshold.kB=120000 | |||
linux.executable.size.threshold.kB=73500 | |||
linux.executable.size.threshold.kB=79000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make these Quarkus/Mandrel specific.
My understanding is that you are increasing the threshold for Quarkus 3.6, but this will make us miss increases happening in 3.2 for instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak Yes. The increase is caused by OpenTelemetry being a much bigger library than OpenTracing apparently.
The "design" of the property files did not take into account the Q versions.
We can start having some per-quarkus-version property files. Perhaps per Mandrel major.minor too.
Non-quarkus apps would have just the Mandrel major.minor?
Wondering how to make it nice and tidy without inflating the logic too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-quarkus apps would have just the Mandrel major.minor?
Yes
Wondering how to make it nice and tidy without inflating the logic too much.
I need something similar in quarkusio/quarkus#36108 and I was thinking about using a directory structure like <quarkus-version>/<mandrel-version>/threshold.properties
. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the threshold bumps which we should better address in another PR since it's a general issue not specific to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with getting this in and do the proper threshold refactoring fix in a follow-up.
Fixes #225
passes now.